Where I live we've hardly ever seen any dry beach hunters let alone water hunters in several years. Maybe a total of 4 water hunters in two years and maybe 7 dry sand hunters on all the beaches we hit. And these are beaches you are only allowed to hunt sunrise to about 9AM when the swimmers start showing up, otherwise they'll kick you out or worse. So it's not like we are missing the guys, because these parks are closes to patrons at night. Probably 5 to 6 beaches in total in a 30 mile radius my little circle of hunting friends frequent, so we keep tabs on just what kind of competition we are seeing, and it's hardly any at all. Always like that. BUT, the gold? Last 3 or 4 years the fresh drops aren't usually gold. More often stainless steel, titanium, or some other junk metal. Reason being in the bad economy, along with high gold prices, people have scrapped their gold for money, and people buying new rings aren't paying the high gold prices.
So I wouldn't blame it on the shows IMO. We aren't seeing really any new hunters from the shows out there. And fact is that sure, a lot of people may think they are going to get rich by watching those shows and so go out and buy a detector, but here's the thing...Detecting, like it or not, (AND NO INSULT INTENDED because I obviously hunt too), is an "odd" hobby to most people. You have to have a certain personality to get heavy into this hobby. For that reason many people might buy machines, but they quickly either lose interest, or they get sick of digging all the trash looking for old coins or rings. Sure, they might hit a modern park and dig a bunch of clads, but even us die hard guys who detect don't often do that. Only a few in our hobby enjoy going to modern parks and digging only clads all day. Got to turn down the discrimination to find the gold, and frankly most people don't have the stomach for digging trash to do that. So it takes a certain character or quality to be a die hard guy who detects.
I would estimate that maybe 5% of our population at the very most has the qualities and personality to find this hobby a true addicting and hard core hobby to pursue for years. Just like some guys love to make their own wine (I do by the way), or fly fish, or hunt, and so on. And I would wager more of the population are die hard hunters or fisherman then those with the traits to find detecting a hard core type of hobby they dive into. Sure, you've got more people who still enjoy it, but many of those are the kind who take the detector out of the closet only a couple times a year just to kill an hour or two of their day, and never dive into it with a passion like those of us who frequent these forums revolving around this great hobby of ours. I'm not of course knocking us as being that "odd" group out there who waves around a funny machine. In fact, I prefer it that way that we are a more rare type of personality. Otherwise every other house on your street would own one and the public (and many private) sites would quickly dry up.
So with these detecting shows..Yes, more people will buy detectors, but all that is going to mean is more used ones on the market, because you can't change personalities. It takes a certain person with a certain fascination with history or exploration to really get into this hobby IMO.